On Tuesday, January 19, 2016 05:24:49 PM Steve Muckle wrote:

On 01/19/2016 03:40 PM, Michael Turquette wrote:

quoted

Right, this was _the_ original impetus behind the design decision to
muck around with struct cpufreq_policy in the hot path which goes al
the way back to v1.

An alternative thought is that we can make copies of the relevant bits
of struct cpufreq_policy that we do not expect too change often. These
will not require any locks as they are mostly read-only data on the
scheduler side of the interface. Or we could even go all in and just
make local copies of the struct directly, during the GOV_START
perhaps, with:

I believe this is a good first step as it avoids reworking a huge amount
of locking and can get us to something functionally correct. It is what
I had proposed earlier, copying the enabled CPUs and freq table in
during the governor start callback. Unless there are objections to it
I'll add it to the next schedfreq RFC.

quoted

...

quoted

Well if we're going to try an optimize out every single false-positive
wakeup then I think that the cleanest long term solution would be
rework the per-policy locking around struct cpufreq_policy to use a
raw spinlock.

It would be nice if the policy lock was a spinlock but I don't know how
easy that is. From a quick look at cpufreq there's a blocking notifier
chain that's called with rwsem held, so it looks messy. Potentially long
term indeed.

quoted

quoted

Also it'd be good I think to avoid building in an assumption that we'll
never want to run solely in the fast (atomic) path. Perhaps ARM won't,
and x86 may never use this, but it's reasonable to think another
platform might come along which uses cpufreq and has the capability to
kick off cpufreq transitions swiftly and without sleeping. Maybe ARM
platforms will evolve to have that capability.

The current design of the cpufreq subsystem and its interfaces have
made this choice for us. sched-freq is just another consumer of
cpufreq, and until cpufreq's own locking scheme is improved then we
have no choice.

I did not word that very well - I should have said, we should avoid
building in an assumption that we never want to try and run in the fast
path.

AFAICS, once we've calculated that a frequency change is required we can
down_write_trylock(&policy->rwsem) in the fast path and go ahead with
the transition, if the trylock succeeds and the driver supports fast
path transitions. We can fall back to the slow path (waking up the
kthread) if that fails.

quoted

This discussion is pretty useful. Should we Cc lkml to this thread?

Done (added linux-pm, PeterZ and Rafael as well).

Thanks!

One comment here (which may be a bit off in which case please ignore it).

You seem to be thinking that sched-freq needs to be a cpufreq governor
and thus be handled in the same way as ondemand, for example.

However, this doesn't have to be the case in principle.  For example,
if we have a special driver callback specifically to work with sched-freq,
it may just use that callback and bypass (almost) all of the usual
cpufreq mechanics.  This way you may avoid worrying about the governor
locking and related ugliness entirely.

Thanks,
Rafael