Re: [PATCH v2 0/4] cpufreq governors and Intel P state driver compatibility
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2015-12-16 19:34:53
On Tue, 2015-12-08 at 14:31 -0800, Srinivas Pandruvada wrote:
Intel P State driver implements two policies, performance and powersave. The powersave policy is similar to ondemand cpufreq governor when using acpi-cpufreq. This causes lots of confusion among users. This results in invalid comparison of performance when acpi-cpufreq and Intel P state performance is compared. The reason Intel P state called powersave when it actually implemented ondemand style P State selection, because the cpufreq core only allows two generic policies "performance and powersave" for drivers which has setpolicy() interface. All drivers using this interface are forced to support these two policies. This patchset adds feature to have configurable generic policies and allows ondemand as one of the policy. With this approach, Intel P state now adds support for ondemand policy and power save policy both in addition to performance.
Since there is negative feedback from Redhat and Suse as this will cause more confusion to their customers, I will drop this patchset. Thanks for reviews and feedback. Thanks, Srinivas
v2 - Suggestion by Viresh to remove callback to get policies - Document update for cpufreq cpu-drivers - Dropped powersave patch, so that it will still default to ondemand as a possible option suggested by Thomas. If it breaks any distros are user, who were using Intel P state driver with powersave, please comment. v1 base version To be done: Intel P state document update Srinivas Pandruvada (4): cpufreq: Add configurable generic policies cpufreq: Add ondemand as a generic policy Documentation: cpu-freq: update setpolicy documentation cpufreq: intel_pstate: Change powersave to ondemand policy Documentation/cpu-freq/cpu-drivers.txt | 9 +++++++-- drivers/cpufreq/cpufreq.c | 17 ++++++++++++++++- drivers/cpufreq/intel_pstate.c | 14 ++++++++------ include/linux/cpufreq.h | 4 +++- 4 files changed, 34 insertions(+), 10 deletions(-)