Thread (9 messages) 9 messages, 4 authors, 2015-10-10

Re: [PATCH] thermal: cpu_cooling: Remove usage of devm functions

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2015-08-19 12:02:16
Also in: lkml

On 19-08-15, 17:27, Vaishali Thakkar wrote:
quoted
I will rather ask you to do this:
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 620dcd405ff6..a04055ea5d94 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -584,8 +584,8 @@ static int cpufreq_get_requested_power(struct
thermal_cooling_device *cdev,
        if (trace_thermal_power_cpu_get_power_enabled()) {
                u32 ncpus = cpumask_weight(&cpufreq_device->allowed_cpus);

-               load_cpu = devm_kcalloc(&cdev->device, ncpus, sizeof(*load_cpu),
-                                       GFP_KERNEL);
+               load_cpu = kcalloc(&cdev->device, ncpus, sizeof(*load_cpu),
+                                  GFP_KERNEL);
        }
Sorry. I forgot to ask you one more thing. devm_kcalloc takes one more
argument then
kcalloc. So, the change I did is correct I guess.
Right, there is an extra argument in my code.

-- 
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help