[PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2015-07-31 08:39:16
Also in:
lkml
Subsystem:
device frequency (devfreq), the rest · Maintainers:
MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2015-08-03 · Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) · Viresh Kumar <viresh.kumar@linaro.org>
- 2015-08-03 · Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) · MyungJoo Ham <myungjoo.ham@samsung.com>
- 2015-08-03 · Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) · Viresh Kumar <viresh.kumar@linaro.org>
- 2015-08-03 · Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) · MyungJoo Ham <myungjoo.ham@samsung.com>
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/devfreq/devfreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index ca1b362d77e2..f28a1fae5691 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c@@ -53,7 +53,7 @@ static struct devfreq *find_device_devfreq(struct device *dev) { struct devfreq *tmp_devfreq; - if (unlikely(IS_ERR_OR_NULL(dev))) { + if (IS_ERR_OR_NULL(dev)) { pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); return ERR_PTR(-EINVAL); }
@@ -133,7 +133,7 @@ static struct devfreq_governor *find_devfreq_governor(const char *name) { struct devfreq_governor *tmp_governor; - if (unlikely(IS_ERR_OR_NULL(name))) { + if (IS_ERR_OR_NULL(name)) { pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); return ERR_PTR(-EINVAL); }
--
2.4.0