Thread (24 messages) 24 messages, 2 authors, 2015-06-26

Re: [PATCH 07/10] cpufreq: ondemand: queue work for policy->cpus together

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2015-06-26 08:52:36

On 26-06-15, 13:58, Preeti U Murthy wrote:
quoted
+		/*
+		 * Checking this for any CPU of the policy is fine. As either
+		 * all would have queued work or none.
Are you sure that the state of the work will be the same across all
policy cpus ? 'Pending' only refers to twork awaiting for the timer to
fire and then queue itself on the runqueue right ? On some of the
policy->cpus, timers may be yet to fire, while on others it might
already have ?
I think a better way to check this is to check if the governor is
stopped or not. i.e. by checking ccdbs->policy. Will fix that.

-- 
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help