Re: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend'
From: Rafael J. Wysocki <hidden>
Date: 2015-06-15 22:30:17
Also in:
linux-arm-kernel, linux-devicetree
On Saturday, June 13, 2015 02:10:23 PM Viresh Kumar wrote:
On 04-06-15, 21:50, Viresh Kumar wrote:quoted
+ opp-suspend = <&suspend_opp>;quoted
- opp00 { + suspend-opp: opp00 {Minor nit, s/suspend-opp/suspend_opp and here is updated patch From: Viresh Kumar <viresh.kumar@linaro.org> Date: Wed, 20 May 2015 08:27:49 +0530 Subject: [PATCH V8] OPP: Add binding for 'opp-suspend' On few platforms, for power efficiency, we want the device to be configured for a specific OPP while we put the device in suspend state. Add an optional property in operating-points-v2 bindings for that. Acked-by: Nishanth Menon <nm@ti.com> Suggested-by: Nishanth Menon <nm@ti.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Well, I'm kind of wondering what else has been overlooked here. Anyway, if I'm supposed to apply this series, I need an ACK from at least one person listed as an "OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" maintainer. Preferably from Rob.
quoted hunk ↗ jump to hunk
--- Documentation/devicetree/bindings/power/opp.txt | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt index 2938c52dbf84..29f115d26f7d 100644 --- a/Documentation/devicetree/bindings/power/opp.txt +++ b/Documentation/devicetree/bindings/power/opp.txt@@ -74,6 +74,8 @@ This describes the OPPs belonging to a device. This node can have following Missing property means devices have independent clock/voltage/current lines, but they share OPP tables. +- opp-suspend: Phandle of the OPP to set while device is suspended. + * OPP Node@@ -145,9 +147,10 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. cpu0_opp_table: opp_table0 { compatible = "operating-points-v2"; + opp-suspend = <&suspend_opp>; opp-shared; - opp00 { + suspend_opp: opp00 { opp-hz = <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>;@@ -219,13 +222,14 @@ independently. cpu_opp_table: opp_table { compatible = "operating-points-v2"; + opp-suspend = <&suspend_opp>; /* * Missing opp-shared property means CPUs switch DVFS states * independently. */ - opp00 { + suspend_opp: opp00 { opp-hz = <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>;@@ -298,9 +302,10 @@ DVFS state together. cluster0_opp: opp_table0 { compatible = "operating-points-v2"; + opp-suspend = <&suspend_opp0>; opp-shared; - opp00 { + suspend_opp: opp00 { opp-hz = <1000000000>; opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>;@@ -323,9 +328,10 @@ DVFS state together. cluster1_opp: opp_table1 { compatible = "operating-points-v2"; + opp-suspend = <&suspend_opp1>; opp-shared; - opp10 { + suspend_opp: opp10 { opp-hz = <1300000000>; opp-microvolt = <1045000 1050000 1055000>; opp-microamp = <95000>;
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.