Thread (23 messages) 23 messages, 8 authors, 2015-06-02

Re: [PATCH v2 3/8] core: platform: wakeup the parent before trying any driver operations

From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Date: 2015-05-26 13:28:55
Also in: linux-acpi, lkml

On Mon, May 25, 2015 at 01:36:43PM -0400, Alan Stern wrote:
On Mon, 25 May 2015, Andy Shevchenko wrote:
quoted
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>

If the parent is still suspended when a driver probe,
remove or shutdown is attempted, the result may be a
failure.

For example, if the parent is a PCI MFD device that has been
suspended when we try to probe our device, any register
reads will return 0xffffffff.

To fix the problem, making sure the parent is always awake
before using driver probe, remove or shutdown.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/base/platform.c | 21 ++++++++++++++++++++-
Why make the changes here rather than in dd.c?  Is there something 
special about platform devices?
There isn't. That would definitely be better.


Thanks Alan,

-- 
heikki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help