Re: [PATCH 11/22] cpufreq: Replace strnicmp with strncasecmp
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2014-09-16 21:22:51
Also in:
lkml
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2014-09-16 21:22:51
Also in:
lkml
On 16 September 2014 13:51, Rasmus Villemoes [off-list ref] wrote:
The kernel used to contain two functions for length-delimited, case-insensitive string comparison, strnicmp with correct semantics and a slightly buggy strncasecmp. The latter is the POSIX name, so strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper for the new strncasecmp to avoid breaking existing users. To allow the compat wrapper strnicmp to be removed at some point in the future, and to avoid the extra indirection cost, do s/strnicmp/strncasecmp/g. Cc: "Rafael J. Wysocki" <redacted> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/cpufreq/cpufreq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Not really sure about the implementation of these routines but the changes look fine. Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- viresh