Re: [PATCH v4 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM
From: Krzysztof Kozlowski <hidden>
Date: 2014-09-16 09:35:03
Also in:
lkml
From: Krzysztof Kozlowski <hidden>
Date: 2014-09-16 09:35:03
Also in:
lkml
On wto, 2014-09-16 at 10:20 +0100, Russell King - ARM Linux wrote:
On Tue, Sep 16, 2014 at 10:51:33AM +0200, Krzysztof Kozlowski wrote:quoted
@@ -191,8 +210,11 @@ static int amba_probe(struct device *dev) pm_runtime_enable(dev); ret = pcdrv->probe(pcdev, id); - if (ret == 0) + if (ret == 0) { + if (pm_runtime_is_irq_safe(dev)) + pcdev->irq_safe = 1;Patch looks good, though I'd prefer this to always explicitly initialise pcdev->irq_safe each time a probe succeeds.
No problem, I'll add this and resend. Thank you for feedback, Krzysztof