Re: [PATCH v2 14/15] cpufreq: Add module to register cpufreq on Krait CPUs

On 09/07/14 21:46, Viresh Kumar wrote:

On 6 September 2014 04:17, Stephen Boyd [off-list ref] wrote:

quoted

+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/cpu.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/slab.h>
+#include <linux/pm_opp.h>
+#include <linux/init.h>

Would be good if these can be in alphanumeric order. That helps maintaining
them later on..

Ok.

quoted

+static int __init qcom_cpufreq_populate_opps(void)
+{
+       int len, num_rows, i, k;
+       char table_name[] = "qcom,speedXX-pvsXX-bin-vXX";
+       struct device_node *np;
+       struct device *dev;
+       int cpu = 0;
+       int speed, pvs, pvs_ver;
+       int cols;

All the 'int' declarations can be combined in a single line if you would like.

Sure.

quoted

+
+MODULE_DESCRIPTION("Qualcomm CPUfreq driver");

A module author as well?

How about we use git blame instead?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation