Thread (9 messages) 9 messages, 3 authors, 2014-05-23

Re: [PATCH v2] cpufreq: s5pv210: drop check for CONFIG_PM_VERBOSE

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2014-05-23 15:10:50
Also in: lkml

On 23 May 2014 20:35, Paul Bolle [off-list ref] wrote:
quoted hunk ↗ jump to hunk
A pr_err() was added in v3.1. It was guarded by a check for
CONFIG_PM_VERBOSE. The Kconfig symbol PM_VERBOSE was removed in v3.0. So
this pr_err() has never been used. Drop that check and clean up the
message a bit.

Signed-off-by: Paul Bolle <redacted>
---
v1 was called "cpufreq: s5pv210: remove unused call of pr_err()". v2
keeps the pr_err() and trims down its arguments, as Sachin requested.

Still untested.

 drivers/cpufreq/s5pv210-cpufreq.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index ab2c1a40d437..19a10b89fef7 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -175,10 +175,8 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
        mutex_lock(&set_freq_lock);

        if (no_cpufreq_access) {
-#ifdef CONFIG_PM_VERBOSE
-               pr_err("%s:%d denied access to %s as it is disabled"
-                               "temporarily\n", __FILE__, __LINE__, __func__);
-#endif
+               pr_err("Denied access to %s as it is disabled temporarily\n",
+                      __func__);
                ret = -EINVAL;
                goto exit;
        }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help