On Tuesday, May 20, 2014 08:08:11 AM Viresh Kumar wrote:

On 20 May 2014 02:43, Rafael J. Wysocki [off-list ref] wrote:

quoted

What about

        if (error)
                return error;

and then you'd save an indentation level?

Yes.

quoted

Anyway, I find adding of_node* stuff directly to the driver core this way
kind of disgusting as there still are platforms that don't use it.

Can we have a call to a function that will change into an empty stub on such
platforms here, please?

Okay. But can you explain a bit more about how and where those stubs
would be implemented?

In a header file included by cpu.c.  Something like

#if defined(CONFIG_OF) && defined(CONFIG_PM_OPP)
<function header>
#else
static inline <stub>
#endif


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.