On Wednesday, May 21, 2014 09:33:42 AM Viresh Kumar wrote:

On 21 May 2014 02:39, Rafael J. Wysocki [off-list ref] wrote:

quoted

quoted

+     /* Duplicate OPPs ? */
+     if (new_opp->rate == opp->rate) {
+             int ret = (new_opp->u_volt == opp->u_volt) && opp->available ?
+                     0 : -EEXIST;

The parens are not necessary.  And is the direction correct?

What do you mean by direction here ?

The case in which we want to return 0.  Never mind, it's OK.  The parens are still
not necessary, though.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.