On 21 May 2014 19:15, Sudeep Holla [off-list ref] wrote:

[Nit] Not sure if we need this logging on each cpu, may be dev_dbg if you
still
fancy one ? :)

It wouldn't happen on each CPU, but one CPU per policy as others
would return -ENODEV.

I added dev_dbg earlier but then I thought dev_info is better as we may
better show this to everybody as it about the most important device,
i.e. CPU :)

quoted

+       /* Print error only if there is an issue with OPP table */
+       else if (error != -ENOSYS && error != -ENODEV)
+               dev_err(&cpu->dev, "%s: failed to init OPP table for
cpu%d, err: %d\n",
+                       __func__, cpu->dev.id, error);
+}
+#else
+static inline void of_init_cpu_opp_table(struct cpu *cpu) {}
+#endif
+

IMO this could be more generic and applicable for any device if you replace
"struct cpu" with "struct device". I know this is currently used by cpu but
we can extend it's use for any device if needed in future. You can then move
this to pm_opp.h as of_init_dev_opp_table may be.

Probably we will call of_init_opp_table() directly for other devices, as this
function doesn't do anything else, apart from some prints.. So, probably
leave is as is for now, unless a real need arises ?