Thread (22 messages) 22 messages, 4 authors, 2014-02-06

Re: [PATCH v7 2/3] trivial: PM / Hibernate: clean up checkpatch in hibernate.c

From: Joe Perches <joe@perches.com>
Date: 2014-02-04 21:21:21
Also in: linux-mm, lkml

On Tue, 2014-02-04 at 12:43 -0800, Sebastian Capella wrote:
Checkpatch reports several warnings in hibernate.c
printk use removed, long lines wrapped, whitespace cleanup,
extend short msleeps, while loops on two lines.
[]
quoted hunk ↗ jump to hunk
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
[]
quoted hunk ↗ jump to hunk
@@ -765,7 +762,7 @@ static int software_resume(void)
 	if (isdigit(resume_file[0]) && resume_wait) {
 		int partno;
 		while (!get_gendisk(swsusp_resume_device, &partno))
-			msleep(10);
+			msleep(20);
What good is changing this from 10 to 20?
quoted hunk ↗ jump to hunk
@@ -776,8 +773,9 @@ static int software_resume(void)
 		wait_for_device_probe();
 
 		if (resume_wait) {
-			while ((swsusp_resume_device = name_to_dev_t(resume_file)) == 0)
-				msleep(10);
+			while ((swsusp_resume_device =
+					name_to_dev_t(resume_file)) == 0)
+				msleep(20);
here too.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help