Re: [PATCH v2 4/5] cpufreq: arm_big_little_dt: enhance OPP error checking
From: Nishanth Menon <hidden>
Date: 2013-10-03 14:26:27
Also in:
linux-devicetree
On 10/01/2013 08:33 AM, Sudeep KarkadaNagesha wrote:
quoted hunk
From: Sudeep KarkadaNagesha <redacted> Since the OPPs can be specified either through 'operating-points' as tuples or through 'operating-points-phandle' as phandle to the node containing tuples, we need to check for both the properties. Cc: "Rafael J. Wysocki" <redacted> Cc: Viresh Kumar <redacted> Signed-off-by: Sudeep KarkadaNagesha <redacted> --- drivers/cpufreq/arm_big_little_dt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c index 480c0bd..b03d4fe 100644 --- a/drivers/cpufreq/arm_big_little_dt.c +++ b/drivers/cpufreq/arm_big_little_dt.c@@ -35,7 +35,8 @@ static struct device_node *get_cpu_node_with_valid_op(int cpu) { struct device_node *np = of_cpu_device_node_get(cpu); - if (!of_get_property(np, "operating-points", NULL)) { + if (!of_get_property(np, "operating-points", NULL) && + !of_get_property(np, "operating-points-phandle", NULL)) { of_node_put(np); np = NULL; }
generated checkpatch --strict warning:
CHECK: Alignment should match open parenthesis
#28: FILE: drivers/cpufreq/arm_big_little_dt.c:39:
+ if (!of_get_property(np, "operating-points", NULL) &&
+ !of_get_property(np, "operating-points-phandle", NULL)) {
otherwise,
Reviewed-by: Nishanth Menon <redacted>
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html