Re: [PATCH v1 5/6] bitops: Introduce BIT_ULL

From
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date
2013-09-19 16:59:20
Also in
lkml
Reply to
Borislav Petkov, 2013-09-19
On 09/19/2013 09:48 AM, Borislav Petkov wrote:
On Thu, Sep 19, 2013 at 09:00:34AM -0700, Srinivas Pandruvada wrote:
quoted
Adding BIT(x) equivalent for unsigned long long type, BIT_ULL(x).

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jacob Pan <redacted>
Acked-by: Rafael J. Wysocki <redacted>
---
  include/linux/bitops.h | 1 +
  1 file changed, 1 insertion(+)
diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index a3b6b82..34e9e94 100644
--- a/include/linux/bitops.h
+++ b/include/linux/bitops.h
@@ -4,6 +4,7 @@
  
  #ifdef	__KERNEL__
  #define BIT(nr)			(1UL << (nr))
+#define BIT_ULL(nr)		(1ULL << (nr))
We already have BIT_64 for that.
The current definition for BIT_64 is in arch/x86/include/asm/bitops.h. I feel it should be applicable for all architectures and move to some common file.

Thanks,
Srinivas
Thread (14 messages) 14 messages, 3 authors, last reply 2013-09-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help