Thread (5 messages) 5 messages, 3 authors, 2012-12-29

Re: [PATCH] Fix problem with cpufreq_pndemand or cpufreq_conservative

From: Fabio Baltieri <hidden>
Date: 2012-12-29 00:33:48
Also in: lkml

On Fri, Dec 28, 2012 at 05:45:54PM -0600, Larry Finger wrote:
quoted
I wonder if that's avoidable?  The intention is not to create an additional
module, clearly.
It appears not to be possible. I don't know enough about to kmake to
understand why it is forcing a new module. Perhaps some expert knows
what Kconfig or Makefile magic will prevent that.
kbuild is building an additional module just because the makefile is
adding the new objects in the obj-m list directly, as in:

obj-$(CONFIG_CPU_FREQ_GOV_ONDEMAND)     += cpufreq_ondemand.o cpufreq_governor.o
obj-$(CONFIG_CPU_FREQ_GOV_CONSERVATIVE) += cpufreq_conservative.o cpufreq_governor.o

To build just two modules the Makefile would have to be modified [1]
into something into something like:

obj-$(CONFIG_CPU_FREQ_GOV_ONDEMAND)     += cpufreq_ondemand_mod.o
cpufreq_ondemand_mod-y                  := cpufreq_ondemand.o cpufreq_governor.o
obj-$(CONFIG_CPU_FREQ_GOV_CONSERVATIVE) += cpufreq_conservative_mod.o
cpufreq_conservative_mod-y              := cpufreq_conservative.o cpufreq_governor.o

so that only two .o are added to obj-m, but that's not correct either as
you end up with cpufreq_governor symbols exported twice.

I think the only way would be to force cpufreq_governor as builtin with
an automatic Kconfig option.

Fabio

1. http://lxr.linux.no/#linux+v3.7.1/Documentation/kbuild/makefiles.txt#L191

-- 
Fabio Baltieri
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help