Thread (36 messages) 36 messages, 4 authors, 2012-12-07

Re: [RFC PATCH v2 10/10] cpu: No more __stop_machine() in _cpu_down()

From: Srivatsa S. Bhat <hidden>
Date: 2012-12-05 19:13:53
Also in: lkml 

On 12/06/2012 12:38 AM, Oleg Nesterov wrote:
On 12/06, Srivatsa S. Bhat wrote:
quoted
@@ -418,7 +418,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen)
 	}
 	smpboot_park_threads(cpu);

-	err = __stop_machine(take_cpu_down, &tcd_param, cpumask_of(cpu));
+	err = stop_cpus(cpumask_of(cpu), take_cpu_down, &tcd_param);
stop_one_cpu(cpu) ?
Even I was thinking of using that. Paul, any particular reason you chose
stop_cpus() over stop_one_cpu() in [1]?

[1]. https://lkml.org/lkml/2012/10/30/359

Regards,
Srivatsa S. Bhat

  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help