Re: [PATCH 3/6] cgroup: introduce cgroup_taskset and use it in subsys->can_attach(), cancel_attach() and attach()
From: Paul Menage <hidden>
Date: 2011-08-25 09:32:35
On Thu, Aug 25, 2011 at 2:20 AM, Tejun Heo [off-list ref] wrote:
I think having separate ->attach() and ->attach_task() is inherently broken. Look at the memcg discussion I had in this thread for reference and as soon as we need to do something across the tasks being migrated, iteration-by-callback becomes very painful. e.g. let's say memcg wants to find the mm->owner and wants to print warning or fail if that doesn't work out. How would that be implemented if it's iterating by callback.
OK, fair point. See my other email for patch comments. Paul