On Wed, Aug 24, 2011 at 2:34 AM, Turquette, Mike [off-list ref] wrote:

On Tue, Aug 23, 2011 at 12:54 AM, MyungJoo Ham [off-list ref] wrote:

quoted

+               The /sys/devices/.../power/devfreq_cur_freq shows the

Copy/paste error?  Description should reference devfreq_max_freq not
devfreq_cur_freq.

quoted

+               minimum operable frequency of the corresponding device.

Similar to the above.

Thank you. I'll resubmit soon with corrections (and w/ some further
changes to allow governors to have their own sysfs entries and access
more on the DEVFREQ core).

quoted

+
+What:          /sys/devices/.../power/devfreq_set_freq
+Date:          August 2011
+Contact:       MyungJoo Ham [off-list ref]
+Description:
+               The /sys/devices/.../power/devfreq_set_freq sets and shows
+               the user specified desired frequency of the device. The
+               governor may and may not use the value. With the basic
+               governors given with devfreq.c, userspace governor is
+               using the value.

As I stated in patch 3, this should conditionally exist only if the
userspace governor is being used for this device.

Ok, in the next revision, this entry will be removed and replaced with
an entry created by userspace governor.

The existing devfreq_cur_freq covers the read-only case well.

It could be a bit different especially with another device driver
enabling and disabling OPPs and/or PM QoS.

For example, when user states "100MHz" on a device with
"50/100/200MHz", it will use 100. However, if someone has disabled
100MHz with opp_disable, devfreq_cur_freq will automatically changed
to 200 while the user value should remain at 100 in case where 100 is
later re-enabled.

Regards,
Mike

Thank you.


Cheers!

MyungJoo


-- 
MyungJoo Ham (함명주), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm