Re: [PATCH 11/15] OMAP3: powerdomain data: add wake-up latency figures

On Tue, Aug 16, 2011 at 4:25 PM, Santosh [off-list ref] wrote:

On Tuesday 16 August 2011 07:13 PM, jean.pihet@newoldbits.com wrote:

quoted

From: Jean Pihet<redacted>

Figures are added to the power domains structs.

Note: the figures are preliminary figures. More accurate measurements
are needed. Also the conditions of measurements shall be investigated
and described.

Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints
on MPU, CORE and PER.

Signed-off-by: Jean Pihet<redacted>
---
 arch/arm/mach-omap2/powerdomains3xxx_data.c |   77
+++++++++++++++++++++++++++
 1 files changed, 77 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c

b/arch/arm/mach-omap2/powerdomains3xxx_data.c
index 469a920..64446e7 100644

--- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c

@@ -31,6 +31,13 @@

 /*
  * Powerdomains
+ *
+ * The wakeup_lat values are derived from measurements on
+ * the actual target.
+ *
+ * Note: the latency figures are preliminary and only used
+ * for the constraints framework validation.
+ * Actual figures and measurements conditions shall be added.
  */

 static struct powerdomain iva2_pwrdm = {

@@ -52,6 +59,13 @@ static struct powerdomain iva2_pwrdm = {

               [2] = PWRSTS_OFF_ON,
               [3] = PWRSTS_ON,
       },
+       .wakeup_lat = {
+               [PWRDM_FUNC_PWRST_OFF] = 1100,
+               [PWRDM_FUNC_PWRST_OSWR] = UNSUP_STATE,
+               [PWRDM_FUNC_PWRST_CSWR] = 350,
+               [PWRDM_FUNC_PWRST_INACTIVE] = UNSUP_STATE,

This can easily derived from the PWRST flag instead of hardcoding
it this way. Also note that INACTIVE PD isn't supported in mainline
yet because of voltage-domain dependency planned changes.

quoted

+               [PWRDM_FUNC_PWRST_ON] = 0,

All of the PD structures are manually coded. This whole file is
auto-generated and even these field generation needs to follow
that path.

Ok I need to check that. Any pointer on how to generate those?

Jean