Re: [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints
From: Kevin Hilman <hidden>
Date: 2011-08-02 17:49:39
"Rafael J. Wysocki" [off-list ref] writes:
Hi, On Thursday, June 30, 2011, jean.pihet@newoldbits.com wrote:quoted
From: Jean Pihet <redacted> - add a new PM QoS class PM_QOS_DEV_WAKEUP_LATENCY for device wake-up constraints. Due to the per-device nature of the new class the constraints list is stored inside the device dev_pm_info struct instead of the internal per-class constraints lists.I think PM_QOS_DEV_LATENCY might be a better name.quoted
The new class is only available from kernel drivers and so is not exported to user space.It should be available to user space, however, because in many cases drivers simply have no idea what values to use (after all, the use decides if he wants to trade worse video playback quality for better battery life, for example).
FWIW, I think it's wrong to expose the raw per-device constraints directly to userspace. I think it's the responsibility of the subsystems (video, audio, input, etc.) to expose QoS knobs to userspace as they see fit and now allow userspace to tinker directly with QoS constraints. Kevin