Re: [PATCH] PM: Hide CONFIG_PM from users
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2011-02-07 15:00:55
On Mon, Feb 7, 2011 at 15:50, Mark Brown [off-list ref] wrote:
On Tue, Feb 08, 2011 at 01:44:32AM +1100, Stephen Rothwell wrote:quoted
On Mon, 7 Feb 2011 14:18:29 +0000 Mark Brown [off-list ref] wrote:quoted
quoted
Do you mean that these systems require CONFIG_PM be turned off, or just that people tend not to turn it on? If the latter would you expect any ill effects from doing so?quoted
I don't know the answer to either question without testing. All I am saying is that currently the default for CONFIG_PM is "off" and you are changing it to be "on" and there may not have been any testing done of that in some situations. We don't know where it was explicitly turned off any more since we shrank our defconfig files (which was done automatically) ... since it is off by default, it doesn't need to be mentioned in a defconfig unless it needs to be turned on.My suspicion would be that it'll have been turned off by someone hitting return through a config upgrade rather than through deliberate effort. On the other hand if it is essential for some machines to have it disabled they probably want to have somethnig in Kconfig.
$ git grep "CONFIG_PM is not set"
7cf3d73b4360e91b14326632ab1aeda4cb26308d^ -- arch/ | wc -l
256
$
7cf3d73b4360e91b14326632ab1aeda4cb26308d is the commit that introduced
savedefconfig, so that's a safe revision with untrimmed defconfigs.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm