Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs

Hi, Rafael J. Wysocki

Rafael J. Wysocki wrote:

On Thursday 18 February 2010, Jin Dongming wrote:

quoted

Hi, Rafael J. Wysocki

quoted

-	/* Update enable mask, but don't enable the HW GPE as of yet */
-
-	status = acpi_ev_enable_gpe(gpe_event_info, FALSE);

You could preserve some more context.

quoted

I think the above line code should be remained. If it is deleted, the exception 
event will be raised on some machine.

Why would it?  The GPE is still disabled at the hardware level at this point.

Rafael

I am very sorry for my wrong comment. The GPE is still disabled as you wrote.

The error message what I got was not caused by GPE event, it was caused by the "status"
variable which had not been deleted on x86-next tree. And it is also deleted at this
file. So I don't there is problem here.

Best regards,
Jin Dongming