Re: [PATCH 00/07] pm: remove late/early platform driver pm callbacks V2
From: Pavel Machek <hidden>
Date: 2009-06-24 18:56:02
On Wed 2009-06-24 20:48:39, Rafael J. Wysocki wrote:
On Wednesday 24 June 2009, Magnus Damm wrote:quoted
pm: remove late/early platform driver pm callbacks V2 [PATCH 01/07] arm: rework omap suspend_late()/resume_early() [PATCH 02/07] dma: rework dw_dmac suspend_late()/resume_early() [PATCH 03/07] dma: rework txx9dmac suspend_late()/resume_early() [PATCH 04/07] i2c: rework i2c-pxa suspend_late()/resume_early() [PATCH 05/07] i2c: rework i2c-s3c2410 suspend_late()/resume() V2 [PATCH 06/07] usb: rework musb suspend()/resume_early() [PATCH 07/07] pm: remove platform device suspend_late()/resume_early() V2 These patches simply remove ->suspend_late() and ->resume_early() from struct platform_driver. Drivers are converted to dev_pm_ops with CONFIG_SUSPEND in mind. Untested. All patches except [02/07] are known to compile. Signed-off-by: Magnus Damm <redacted>If no one objects, I'd like to take this series into the suspend-2.6 tree as 2.6.32 material. Greg? Pavel, is your ACK for the entire series?
Well, I don't really understand stuff like dw_dmac.c, but it looks basically okay to me. I guess ACK might be okay.
quoted
arch/arm/plat-omap/debug-leds.c | 11 +++++++---- arch/arm/plat-omap/gpio.c | 14 ++++++++++---- drivers/base/platform.c | 36 ------------------------------------ drivers/dma/dw_dmac.c | 15 ++++++++++----- drivers/dma/txx9dmac.c | 15 ++++++++++----- drivers/i2c/busses/i2c-pxa.c | 25 +++++++++++++++++-------- drivers/i2c/busses/i2c-s3c2410.c | 25 ++++++++++++++++--------- drivers/usb/musb/musb_core.c | 18 ++++++++++++------ include/linux/platform_device.h | 2 -- 9 files changed, 82 insertions(+), 79 deletions(-)
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html