Re: [PATCH 4/10] ACPI: register ACPI Fan as generic thermal cooling device
From: Len Brown <lenb@kernel.org>
Date: 2008-02-02 09:08:56
Subsystem:
acpi, the rest · Maintainers:
"Rafael J. Wysocki", Linus Torvalds
Possibly related (same subject, not in this thread)
- 2008-01-17 · [PATCH 4/10] ACPI: register ACPI Fan as generic thermal cooling device · Zhang Rui <rui.zhang@intel.com>
On Thursday 17 January 2008 02:51, Zhang Rui wrote:
quoted hunk
+#ifdef CONFIG_ACPI_PROCFS static struct proc_dir_entry *acpi_fan_dir;@@ -167,7 +213,17 @@ static int acpi_fan_remove_fs(struct acpreturn 0; } +#else +static int acpi_fan_add_fs(struct acpi_device *device) +{ + return 0; +} +static int acpi_fan_remove_fs(struct acpi_device *device) +{ + return 0; +} +#endif
commit 3c602840528cf1aa835e6e32d76a0a45936b8e4c
Author: Len Brown [off-list ref]
Date: Sat Feb 2 04:05:54 2008 -0500
ACPI: fan: build fix for CONFIG_ACPI_PROCFS=n
drivers/acpi/fan.c:340: error: ‘acpi_fan_dir’ undeclared (first use in this function)
Signed-off-by: Len Brown [off-list ref]
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index f6e8165..48cb705 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c@@ -337,10 +337,12 @@ static int __init acpi_fan_init(void) int result = 0; +#ifdef CONFIG_ACPI_PROCFS acpi_fan_dir = proc_mkdir(ACPI_FAN_CLASS, acpi_root_dir); if (!acpi_fan_dir) return -ENODEV; acpi_fan_dir->owner = THIS_MODULE; +#endif result = acpi_bus_register_driver(&acpi_fan_driver); if (result < 0) {