Re: [RFC][PATCH] uli526x: Add suspend and resume routines

On Wednesday, 8 August 2007 14:05, Rafael J. Wysocki wrote:

On Wednesday, 8 August 2007 01:03, Andrew Morton wrote:

quoted

On Sun, 5 Aug 2007 21:14:01 +0200
"Rafael J. Wysocki" [off-list ref] wrote:

quoted

+#ifdef CONFIG_PM_SLEEP
+
+/*
+ *	Suspend the interface.
+ */
+
+static int uli526x_suspend(struct pci_dev *pdev, pm_message_t state)

Since when did suspend and resume methods become dependent upon CONFIG_PM_SLEEP?

We have eight thousand implementations of this, all of which presently
use CONFIG_PM.

Yes, they do, but if CONFIG_PM_SLEEP is not set, they won't be used.

Well, not all of them.  There are some in USB used for runtime power
management and there may be some others like that, but the majority of them
are really only useful for suspend/hibernation.  Like the ones in this patch.

Greetings,
Rafael