On Tue, 2007-07-31 at 04:52 -0600, Eric W. Biederman wrote:

"Huang, Ying" [off-list ref] writes:

quoted

On Tue, 2007-07-31 at 11:10 +0200, Pavel Machek wrote:

quoted

quoted

Index: kexec-tools-1.101/kexec/arch/i386/crashdump-x86.c
===================================================================

--- kexec-tools-1.101.orig/kexec/arch/i386/crashdump-x86.c 2007-07-08

23:00:25.000000000 +0800

quoted

quoted

+++ kexec-tools-1.101/kexec/arch/i386/crashdump-x86.c 2007-07-14

17:06:45.000000000 +0800

quoted

quoted

@@ -428,6 +428,29 @@
 	return 0;
 }
 
+/* Adds the kexec_backup= command line parameter to command line. */
+static int cmdline_add_backup(char *cmdline, unsigned long addr)
+{
+	int cmdlen, len, align = 1024;
+	char str[30], *ptr;
+
+	/* Passing in kexec_backup=xxxK format. Saves space required
+	 * in cmdline. Ensure 1K alignment*/
+	if (addr%align)
+		return -1;
+	addr = addr/align;
+	ptr = str;
+	strcpy(str, " kexec_backup=");
+	ptr += strlen(str);
+	ultoa(addr, ptr);
+	strcat(str, "K");
+	len = strlen(str);
+	cmdlen = strlen(cmdline) + len;
+	if (cmdlen > (COMMAND_LINE_SIZE - 1))
+		die("Command line overflow\n");
+	strcat(cmdline, str);
+	return 0;
+}

This part did not apply for me -- it seems crashdump related and I did
not have that applied. Is it critical?

This is needed for kexec_jump to work properly. Which version of
kexec-tools do you use? This patch is against 1.101. The kdump patch
must be applied before this patch is applied.

Please work against the kexec-tools-testing tree, if you can.
All of the outstanding patches should be there.

OK, I will work against the kexec-tools-testing tree in the next
version.

Best Regards,
Huang Ying