Re: 2.6.19: ACPI reports AC not present after resume from STD
From: Rafael J. Wysocki <hidden>
Date: 2007-02-24 19:53:10
Also in:
linux-acpi, lkml
Hi, On Saturday, 24 February 2007 10:55, Andrey Borzenkov wrote:
On Вторник 13 февраля 2007, Andrey Borzenkov wrote:quoted
On Четверг 07 декабря 2006, Lebedev, Vladimir P wrote:quoted
Please register new bug, attach acpidump and dmesg.http://bugzilla.kernel.org/show_bug.cgi?id=7995 regardsWell, this starts looking like ACPI is not at fault. When reporting AC state ACPI just reads contents of system memory (I presume it gets updated by BIOS/ACPI when AC state changes). It looks like this memory area is restored during resume from STD. I updated mentioned bug report with more detailed description. Now if someone could suggest a way to catch if specific physical address gets saved/restored this would finally explain it.
First, if you want the reserved memory areas to be left alone by swsusp, you need to mark them as 'nosave'. On x86_64 this is done by the function e820_mark_nosave_range() in arch/x86_64/kernel/e820.c that can be ported to i386 with no problems. However, we haven't found that very useful, so far, since no one has ever reported any problems with the current approach, which is to save and restore them. Second, if you want to know if a suspicious page frame is saved by swsusp, it's best to stick a test and a printk in kernel/power/pack_pfns() and artificially fail the suspend, eg. by making swsusp_write() always return an error.
Gratefully waiting for patches to test :)
Sorry, no patches this time. I have more urgent problem to fix. :-) Greetings, Rafael
quoted
quoted
-----Original Message----- From: Alexey Starikovskiy [mailto:alexey.y.starikovskiy@linux.intel.com] Sent: Thursday, December 07, 2006 10:49 PM To: Rafael J. Wysocki Cc: Karasyov, Konstantin A; Andrey Borzenkov; linux-acpi@vger.kernel.org; Lebedev, Vladimir P Subject: Re: 2.6.19: ACPI reports AC not present after resume from STD Rafael J. Wysocki wrote:quoted
Hi, On Thursday, 7 December 2006 19:57, Karasyov, Konstantin A wrote:quoted
Hi, Unfortunately, I cannot reproduce this bug on my system, but theproblemquoted
quoted
could be solved by adding a resume handler for AC adapter device.Couldquoted
quoted
you try the attached patch to see if it helps.I can reproduce it and the patch doesn't help. Greetings, RafaelAny ACPI errors in dmesg? Regards, Alex.
-- If you don't have the time to read, you don't have the time or the tools to write. - Stephen King - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html