Re: [patch 2.6.13-rc3] pci: restore BAR values after D3hot->D0 for devices that need it
From: Greg KH <hidden>
Date: 2005-08-02 17:34:28
Also in:
lkml
From: Greg KH <hidden>
Date: 2005-08-02 17:34:28
Also in:
lkml
On Sun, Jul 31, 2005 at 08:36:53PM +0100, Ralf Baechle wrote:
On Wed, Jul 27, 2005 at 10:19:44AM -0400, John W. Linville wrote:quoted
Some PCI devices (e.g. 3c905B, 3c556B) lose all configuration (including BARs) when transitioning from D3hot->D0. This leaves such a device in an inaccessible state. The patch below causes the BARs to be restored when enabling such a device, so that its driver will be able to access it. The patch also adds pci_restore_bars as a new global symbol, and adds a correpsonding EXPORT_SYMBOL_GPL for that. Signed-off-by: John W. Linville <redacted> --- Some firmware (e.g. Thinkpad T21) leaves devices in D3hot after a (re)boot. Most drivers call pci_enable_device very early, so devices left in D3hot that lose configuration during the D3hot->D0 transition will be inaccessible to their drivers.Tested with the 3com 3c556B Hurricane mini-PCI card in the IBM A21P. Without this patch the 3c59x driver has not been able to read the MAC address of the card's EEPROM with ACPI enabled, now it works with and without ACPI support. This patch should settle at least some of the issues in http://bugzilla.kernel.org/show_bug.cgi?id=1188.
Thanks for testing. I'm still going to hold off sending this in for 2.6.13 and wait for 2.6.14, unless people really think it should go in now. greg k-h