Re: [RFC PATCH 1/5] phy: core: Use EOPNOTSUPP for disabled blob return value

From
Inochi Amaoto <inochiama@gmail.com>
Date
2026-09-22 06:10:55
Also in
dri-devel, linux-ide, linux-usb, lkml
Reply to
Greg Kroah-Hartman, 2026-09-22
On Tue, Sep 22, 2026 at 07:35:19AM +0200, Greg Kroah-Hartman wrote:
On Tue, Sep 22, 2026 at 10:47:16AM +0800, Inochi Amaoto wrote:
quoted
Currently, the phy subsystem uses ENOSYS for dummy blob functions,
it does not reflect the function state correctly. As kernel already
has EOPNOTSUPP for disabled blob function, replace ENOSYS with
EOPNOTSUPP for a clear return value.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 include/linux/phy/phy.h | 52 ++++++++++++++++++++---------------------
 1 file changed, 26 insertions(+), 26 deletions(-)
Based on the other patches in this series, this patch now breaks the
users, right?  Shouldn't this all happen at once?

thanks,

greg k-h
It will break, and the change should happen at one. But I think
the affect should be limited as it only affect a special edge
case: build kernel with CONFIG_GENERIC_PHY disabled. So the
break should be limited.

IIRC I was told to seperate the patch into small part so each
maintainer can take its own. Is it fine to squash these patches
into one in this a case?

Regards,
Inochi




-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Thread (14 messages) 14 messages, 3 authors, last reply 2026-09-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help