Re: [PATCH v4 01/12] dt-bindings: phy: Document MT8195 and MT8196 DisplayPort PHYs
From: sashiko-bot@kernel.org
Date: 2026-09-10 09:37:30
Also in:
dri-devel, linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] The proposed PHY binding models the PHY as a standalone device with a `reg` region that overlaps the existing DP/eDP MAC controller, causing resource conflicts and breaking backward compatibility. -- commit 4c8f0a6ba6ee74a2973e7591e070dd77de336be6 Author: AngeloGioacchino Del Regno [off-list ref] dt-bindings: phy: Document MT8195 and MT8196 DisplayPort PHYs This commit adds bindings for the DisplayPort and Embedded DisplayPort PHYs found in the MediaTek MT8195 and MT8196 SoCs. The PHY supports varying impedance calibrations to reach an optimal EYE signal pattern.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8195-dp-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8195-dp-phy.yaml new file mode 100644 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/mediatek,mt8195-dp-phy.yaml@@ -0,0 +1,77 @@
[ ... ]
+properties: + compatible: + enum: + - mediatek,mt8195-dp-phy + - mediatek,mt8196-edp-phy + + reg: + maxItems: 1
[Severity: High] Will this reg property overlap with the existing DP/eDP MAC controller? If this new binding is implemented as a standalone device node, the PHY driver (mtk_dp_phy_probe) and the DP driver (mtk_dp_dt_parse) will both call devm_platform_ioremap_resource() on the same memory space. Since the DP controller currently maps the entire 32KB region and the PHY binding requires mapping the first 8KB, will they conflict when requesting the memory region from iomem_resource? It appears the second driver to probe would fail with -EBUSY, breaking backward compatibility for display functionality. [ ... ]
+additionalProperties: false
+
+examples:
+ - |
+ phy@1c500000 {
+ compatible = "mediatek,mt8195-dp-phy";
+ reg = <0x1c500000 0x2000>;[Severity: High] Does this example demonstrate mapping the PHY exactly where the existing mediatek,mt8195-edp-tx device is mapped in older device trees? If the device tree uses this newly documented PHY node layout, it seems a regression would occur unconditionally during system boot due to the conflicting memory regions.
+ #phy-cells = <0>;
[ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260910092038.48291-1-angelogioacchino.delregno@collabora.com?part=1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy