Re: [PATCH 05/13] ARM: orion/dove/mv78xx0: remove all board files

On Tue, Sep 8, 2026, at 18:11, sashiko-bot@kernel.org wrote:

[Severity: Low]
Since all the board files like arch/arm/mach-orion5x/ts78xx-setup.c are
removed in this patch, should the MAINTAINERS entry for the TS-78xx platform
further down in this file also be removed?

The pattern F: arch/arm/mach-orion5x/ts78xx-* now points to deleted files,
which leaves an orphaned entry for Alexander Clouter.

I fixed this instance now. I tried to automate this with a script
but could not figure out how to deal with wildcard matches and
only did the ones that have an exact file match.

If anyone has suggestions for doing this better, please let me know,
or run your script on 
https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=board-remove-7.3
and send me the results.

[ ... ]

quoted

diff --git a/arch/arm/mach-orion5x/Makefile b/arch/arm/mach-orion5x/Makefile
index 6f54d7fef27a7..7e9634e043185 100644
--- a/arch/arm/mach-orion5x/Makefile
+++ b/arch/arm/mach-orion5x/Makefile

@@ -2,15 +2,6 @@
 ccflags-y := -I$(srctree)/arch/arm/plat-orion/include
 
 obj-y				+= common.o pci.o irq.o mpp.o
-obj-$(CONFIG_MACH_KUROBOX_PRO)	+= kurobox_pro-setup.o
-obj-$(CONFIG_MACH_TERASTATION_PRO2)	+= terastation_pro2-setup.o

[Severity: Low]
Are irq.o and mpp.o now completely unreachable code?

Since all the board files that called into these APIs have been removed,
it appears these objects are now unnecessarily compiled into the kernel
image. Should they be removed from obj-y here?

Added this to the patch, removing the two files and recursively
seven more that become orphaned afterwards:

 arch/arm/mach-orion5x/Makefile                |   2 +-
 arch/arm/mach-orion5x/irq.c                   |  51 ---
 arch/arm/mach-orion5x/irqs.h                  |   9 -
 arch/arm/mach-orion5x/mpp.c                   |  41 --
 arch/arm/mach-orion5x/mpp.h                   | 130 ------
 arch/arm/plat-orion/Makefile                  |   4 +-
 arch/arm/plat-orion/gpio.c                    | 616 --------------------------
 arch/arm/plat-orion/include/plat/irq.h        |  15 -
 arch/arm/plat-orion/include/plat/mpp.h        |  34 --
 arch/arm/plat-orion/include/plat/orion-gpio.h |  38 --
 arch/arm/plat-orion/irq.c                     |  39 --
 arch/arm/plat-orion/mpp.c                     |  82 ----
 13 files changed, 2 insertions(+), 1066 deletions(-)

This leaves only pcie.{c,h} in arch/arm/plat-orion/, which
should be folded into arch/arm/mach-orion5x/pci.c, along
with parts of arch/arm/kernel/bios32.c that nothing else
uses any more. I don't have a patch for that yet.

      Arnd

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy