Thread (8 messages) flat view 8 messages, 3 authors, 11d ago

Re: [PATCH v2 1/2] dt-bindings: phy: airoha: Document support for AN7583 Gen3 PCIe PHY

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-08-31 06:52:00
Also in: linux-arm-kernel, linux-devicetree, lkml

On Thu, Aug 27, 2026 at 02:21:20PM +0200, Christian Marangi wrote:
+
+examples:
+  - |
+    #include <dt-bindings/phy/phy.h>
+
+    phy@1fc7f000 {
+        compatible = "airoha,an7583-pcie-gen3-phy";
+        reg = <0x1fc7f000 0xfff>,
+              <0x1fc7e000 0xfff>,
Sashiko has a valid point here.

This should reflect real hardware, not current driver. It is very, very
unlikely that hardware designers designed a block of 0xfff size or 0x4
+              <0x1fc30044 0x4>,
+              <0x1fc35030 0x4>;
Best regards,
Krzysztof


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help