Re: [PATCH v2 02/15] dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller
flat view
From: sashiko-bot@kernel.org
Date: 2026-08-28 13:54:16
Also in:
dri-devel, linux-clk, linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The `ports` property describes one input and one output port but fails to enforce this constraint in the YAML structure. -- commit 419cb2b368875cbe282124810522d401e4b0c458 Author: Michal Wilczynski [off-list ref] dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller This commit adds the device tree binding schema for the StarFive JH7110 Innosilicon HDMI controller.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/display/bridge/starfive,jh7110-inno-hdmi-controller.yaml b/Documentation/devicetree/bindings/display/bridge/starfive,jh7110-inno-hdmi-controller.yaml new file mode 100644 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/starfive,jh7110-inno-hdmi-controller.yaml
[ ... ]
quoted hunk ↗ jump to hunk
+ phy-names: + const: hdmi-phy + + ports: + $ref: /schemas/graph.yaml#/properties/ports + description: + A graph node with one input port and one output port.
[Severity: Medium] Does this missing structure allow invalid device trees to pass validation? The description states there is one input port and one output port, but the YAML lacks the internal property constraints (such as port@0 and port@1) and the associated required list. Without these explicit definitions, device trees missing the expected nodes or adding extraneous invalid ports will silently pass dt_binding_check despite violating the hardware topology constraints described. Could explicit definitions and constraints for port@0 and port@1 be added here to properly enforce the port counts? [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com?part=2 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy