Re: [PATCH 6/8] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue
From: sashiko-bot@kernel.org
Date: 2026-08-12 01:11:25
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing `#include <linux/bitfield.h>` for the `FIELD_PREP` macro. --
--- Patch [6]: [PATCH 6/8] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue ---commit b7b018e07e03e9eca049254747c91235246ffef8 Author: Marek Vasut [off-list ref] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue This commit adds support for the ST STM32MP2 DWC3 USB controller glue logic to the generic DWC3 platform driver.
quoted hunk ↗ jump to hunk
diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c index ca69ac0eb07ce..0946ed61647b6 100644 --- a/drivers/usb/dwc3/dwc3-generic-plat.c +++ b/drivers/usb/dwc3/dwc3-generic-plat.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -85,6 +91,38 @@ static int dwc3_spacemit_k1_init(struct dwc3_generic *dwc3g) return 0; } +static int dwc3_stm32mp25_init(struct dwc3_generic *dwc3g) +{
[ ... ]
+ return regmap_update_bits(regmap, drcr, + STM32MP2_USB3DRCR_HOST_PORT_POWER_CONTROL_PRESENT | + STM32MP2_USB3DRCR_OVRCUR_POLARITY | + STM32MP2_USB3DRCR_VBUSEN_POLARITY | + STM32MP2_USB3DRCR_USB2ONLYD | + STM32MP2_USB3DRCR_USB2ONLYH, + FIELD_PREP(STM32MP2_USB3DRCR_HOST_PORT_POWER_CONTROL_PRESENT, + prt_pwr_ctrl) |
[Severity: Low] Does this file need to include linux/bitfield.h? The FIELD_PREP macro is used here to prepare the bitfields, but the header defining it does not appear to be included. If the header isn't pulled in transitively, will this result in a build failure? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260812010157.1772849-1-marex@nabladev.com?part=6 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy