Re: [PATCH v4 1/3] dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port and OTG
From: sashiko-bot@kernel.org
Date: 2026-07-20 10:28:22
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `#phy-cells` property uses an `enum` constraint instead of a `const` constraint, violating Device Tree Bindings guidelines. --
--- Patch [1]: [PATCH v4 1/3] dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port and OTG ---commit 676c30318df404b9fb25b710326b359f41a5cf10 Author: Joey Lu [off-list ref] dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port and OTG This commit updates the Nuvoton MA35D1 USB2 PHY binding to support dual ports managed by the same hardware block. It modifies the #phy-cells property to allow values of 0 or 1 for port selection, while preserving backward compatibility. It also introduces optional properties for resistor calibration trim codes and over-current detect polarity.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml index fff858c909a06..1bd22dd0e5fc5 100644 --- a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml
[ ... ]
quoted hunk ↗ jump to hunk
@@ -15,7 +27,12 @@ properties: - nuvoton,ma35d1-usb2-phy "#phy-cells": - const: 0 + enum: [0, 1]
[Severity: Low] Does this violate the device tree binding subsystem rules for cell-count properties? The guidelines specify that each cell-count property must have a const constraint matching the hardware, rather than an enum constraint. If the hardware requires different configurations depending on the variant or backward compatibility, should this be enforced using conditional if-then blocks instead of allowing either value unconditionally?
+ description: + When 0, the node exposes PHY0 only and consumers reference it + with no cell argument. When 1, the single cell selects the port, + with 0 for the OTG port (USB0, shared with DWC2 gadget controller) + and 1 for the host-only port (USB1).
[ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260720102222.251179-1-a0987203069@gmail.com?part=1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy