Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema introduces a new `ports` object to link to the USB-C connector but fails to remove or properly restrict the legacy `port` property, creating an ambiguous and conflicting configuration path.
--

Note: Due to recitation restrictions, the standard inline diff quoting format
has been altered. The following is a free-form summary of the review findings.

commit 097123c73fce6d7ce6f4755a83ce1362c8caefeb
Author: Sebastian Reichel [off-list ref]
dt-bindings: phy: rockchip-usbdp: add improved ports scheme

This commit introduces a proper port scheme for the Rockchip USBDP PHY,
following the Qualcomm QMP USB4-USB3-DP PHY controller binding. It adds an
additional port for the USB-C SBU port to support USB-C DP AltMode.

[Severity: Low]
The schema introduces a new ports object to link to the USB-C connector
but retains the legacy port property without marking it as deprecated.

Since both the legacy port and the new ports properties are present in
the schema properties, could a device tree define both simultaneously and
still pass validation?

Would it be appropriate to add a oneOf exclusion constraint to ensure these
mutually-exclusive graph paradigms cannot be defined at the same time?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-rockchip-usbdp-cleanup-v9-0-e31efbb62d2e@collabora.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy