On 10/13/2025 4:44 PM, Wesley Cheng wrote:

On 10/10/2025 5:04 PM, Krzysztof Kozlowski wrote:

quoted

On 07/10/2025 00:19, Wesley Cheng wrote:

quoted

The Glymur USB subsystem contains a multiport controller, which utilizes
two QMP UNI PHYs.  Add the proper compatible string for the Glymur 
SoC, and
the required clkref clock name.

Signed-off-by: Wesley Cheng <redacted>
---
  .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml   | 35 +++++++++++++++++++
  1 file changed, 35 insertions(+)

diff --git 

a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index a1b55168e050..b0ce803d2b49 100644
--- 
a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ 
b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml

@@ -16,6 +16,7 @@ description:

  properties:
    compatible:
      enum:
+      - qcom,glymur-qmp-usb3-uni-phy
        - qcom,ipq5424-qmp-usb3-phy
        - qcom,ipq6018-qmp-usb3-phy
        - qcom,ipq8074-qmp-usb3-phy

@@ -62,6 +63,8 @@ properties:

    vdda-pll-supply: true
+  refgen-supply: true
+
    "#clock-cells":
      const: 0

@@ -157,6 +160,25 @@ allOf:

          compatible:
            contains:
              enum:
+              - qcom,glymur-qmp-usb3-uni-phy
+    then:
+      properties:
+        clocks:

Missing minItems.

Hi Krzysztof,

Won't the minItems be inherited by the base definition?

Ah...are you saying to define minItems to 5 as well, since we need to 
have all 5 clocks handles defined to work?

Thanks
Wesley Cheng

quoted

quoted

+          maxItems: 5
+        clock-names:
+          items:
+            - const: aux
+            - const: clkref
+            - const: ref

What is the difference between these two? Which block INPUTs
(important!) they represent?

clkref is the TCSR reference clock switch, and the ref is the actual CXO 
handle.

Thanks
Wesley Cheng

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy