Thread (20 messages) 20 messages, 4 authors, 2025-07-04

Re: [PATCH 2/7] dt-bindings: soc: imx-blk-ctrl: add MIPI CSI2 dphy support

From: Frank Li <frank.li@nxp.com>
Date: 2025-07-02 18:02:17
Also in: imx, linux-arm-kernel, linux-devicetree, linux-media, lkml

On 02/07/2025 00:06, Frank Li wrote:
quoted
Add child node dphy-rx, which export phys interface to MIPI CSI2
controller.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
imx media blk ctrl combined many small glue logic registers for display
, camera, power, clk and reset.

There are some discussion at
https://lore.k/
ernel.org%2Fall%2F4414669.ejJDZkT8p0%40steina-
w%2F&data=05%7C02%7CFrank.Li%40nxp.com%7C7ade0a318b37496d628
608ddb93398af%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
638870353425054747%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGk
iOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIj
oyfQ%3D%3D%7C0%7C%7C%7C&sdata=1gHgVYaxpYxqwBoJVSRJKzbtG3WY
E%2Beb1BqkaGEctUA%3D&reserved=0
Sorry, I have to use stupid outlook reply this email because my git send email
always report failure, not sure if company block it. I am trying to fix it.
quoted
to define whole schema for this.

But there are some difficults to cover whole once.

Plan use two steps to complete it
- add all camera related property and subnode
- add all display related property and subnode
And what was the comment there?

"Binding is supposed to be complete. We have several examples when people
added children one-by-one, everytime with different reasoning about
child addressing."

NAK. At least try to read previous discussion.
I read previous your comments, otherwise, I can't put this in cover letter.
"to define whole schema for this".

I understand what your point. But I met some difficult and want to discuss
with you and provided implement path for this.

unlike other individual ip (like UART), there are clearly abstraction for
reg clock ...

CSR bindle some miscellaneous control for difference IPs. Some is easy to
abstract, such reset, clock ... Some is not. It is hard to ensure full
subnodes with good, workable abstraction to for all devices, which used
this module once.

For example: driver need touch a bit of this CSR, but we missed at begin.
We need find new interfaces, some time it is disaster for whole subnode
binding. We don't want to wrong use a reset interface to work around driver
need touch a bits of CSR.

So I try to upstream "confidence" part gradually.

Frank
Best regards,
Krzysztof
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help