Re: [PATCH] phy: ocelot-serdes: Fix IS_ERR vs NULL bug in serdes_probe()
From: Colin Foster <colin.foster@in-advantage.com>
Date: 2024-10-31 14:31:20
Also in:
lkml
From: Colin Foster <colin.foster@in-advantage.com>
Date: 2024-10-31 14:31:20
Also in:
lkml
On Thu, Oct 31, 2024 at 08:38:47PM +0800, Jinjie Ruan wrote:
dev_get_regmap() return NULL and never return ERR_PTR(). check NULL to fix it. Cc: stable@vger.kernel.org Fixes: 672faa7bbf60 ("phy: phy-ocelot-serdes: add ability to be used in a non-syscon configuration") Signed-off-by: Jinjie Ruan <redacted> --- drivers/phy/mscc/phy-ocelot-serdes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/phy/mscc/phy-ocelot-serdes.c b/drivers/phy/mscc/phy-ocelot-serdes.c index 1cd1b5db2ad7..77ca67ce6e91 100644 --- a/drivers/phy/mscc/phy-ocelot-serdes.c +++ b/drivers/phy/mscc/phy-ocelot-serdes.c@@ -512,8 +512,8 @@ static int serdes_probe(struct platform_device *pdev) res->name); } - if (IS_ERR(ctrl->regs)) - return PTR_ERR(ctrl->regs); + if (!ctrl->regs) + return -EINVAL; for (i = 0; i < SERDES_MAX; i++) { ret = serdes_phy_create(ctrl, i, &ctrl->phys[i]);-- 2.34.1
Good find. Acked-by: colin.foster@in-advantage.com Revieved-by: colin.foster@in-advantage.com -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy