Re: [PATCH 02/19] remoteproc: qcom: pas: Add QCS8300 remoteproc support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-09-04 09:36:19
Also in:
linux-arm-kernel, linux-arm-msm, linux-devicetree, linux-iommu, linux-pm, linux-remoteproc, linux-scsi, lkml
On 04/09/2024 10:33, Jingyi Wang wrote:
quoted hunk ↗ jump to hunk
Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300 platform. Co-developed-by: Xin Liu <redacted> Signed-off-by: Xin Liu <redacted> Signed-off-by: Jingyi Wang <redacted> --- drivers/remoteproc/qcom_q6v5_pas.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index ef82835e98a4..f92ccd4921b7 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c@@ -1416,6 +1416,9 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init }, { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, + { .compatible = "qcom,qcs8300-adsp-pas", .data = &sa8775p_adsp_resource}, + { .compatible = "qcom,qcs8300-cdsp-pas", .data = &sa8775p_cdsp0_resource}, + { .compatible = "qcom,qcs8300-gpdsp-pas", .data = &sa8775p_gpdsp0_resource},
What's the point of this? You have entire commit msg to explain such weird duplication. Otherwise sorry, don't duplicate unnecessarily. Devices are compatible, aren't they? Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy