Re: [PATCH 6/9] arm64: dts: qcom: ipq5332: Add USB3 related nodes
From: Krzysztof Kozlowski <hidden>
Date: 2023-08-29 17:03:32
Also in:
linux-arm-kernel, linux-arm-msm, linux-devicetree, linux-usb, lkml
On 29/08/2023 15:58, Praveenkumar I wrote:
quoted hunk ↗ jump to hunk
Add SS UNIPHY and update controller node for USB3. Signed-off-by: Praveenkumar I <redacted> --- This patch depends on the below series which adds support for USB2 in IPQ5332 https://lore.kernel.org/all/cover.1692699472.git.quic_varada@quicinc.com/ (local) arch/arm64/boot/dts/qcom/ipq5332.dtsi | 39 ++++++++++++++++++++++----- 1 file changed, 32 insertions(+), 7 deletions(-)diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi index e6baf694488c..7fbe6c9f4784 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi@@ -158,6 +158,27 @@ usbphy0: phy@7b000 { status = "disabled"; }; + ssuniphy0: ssuniphy@4b0000 {
From where did you get such pattern of node naming? Downstream, right? Please, do not work on downstream but upstream. Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy