Re: [PATCH v1 6/6] arm64: dts: qcom: sa8775p-ride: enable pcie nodes
From: Krzysztof Kozlowski <hidden>
Date: 2023-07-06 06:39:09
Also in:
linux-arm-msm, linux-devicetree, linux-pci, lkml
On 05/07/2023 10:17, Mrinmay Sarkar wrote:
quoted hunk ↗ jump to hunk
Enable pcie0, pcie1 nodes and their respective phy's. Signed-off-by: Mrinmay Sarkar <redacted> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+)diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts index ab767cfa51ff..4a39294259fe 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts@@ -443,6 +443,74 @@ qup_uart17_rx: qup0-uart17-rx-pins { bias-pull-down; }; }; + + pcie0_default_state: pcie0-default { + perst {
It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy