Thread (17 messages) 17 messages, 6 authors, 2023-03-14

Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller driver

From: Conor Dooley <conor@kernel.org>
Date: 2023-03-14 15:37:36
Also in: linux-devicetree, linux-media, lkml

On Tue, Mar 14, 2023 at 04:20:09PM +0200, Sakari Ailus wrote:
Hi Eugen,

On Fri, Dec 16, 2022 at 04:37:16PM +0200, Eugen Hristev wrote:
quoted
From: Luis Oliveira <redacted>

Add the Synopsys MIPI CSI-2 controller driver. This
controller driver is divided in platform functions and core functions.
This way it serves as platform for future DesignWare drivers.

Signed-off-by: Luis Oliveira <redacted>
Co-developed-by: Eugen Hristev <redacted>
[eugen.hristev@microchip.com:
Add format SRGGB10 to supported format list.
Write the data type to the correct register DATA_IDS_1.
Changed dev_info to dev_dbg to remove extra chatty messages
Avoid overwriting static array of formats]
Signed-off-by: Eugen Hristev <redacted>
[luis.oliveira@synopsys.com: Add MIPI CSI-2 platform data]
Signed-off-by: Luis Oliveira <redacted>
[eugen.hristev@microchip.com:
Add support for periph clock and phy clock
Fix enum_mbus function
Implement get_mbus_config
Implement media controller
Update to use fwnode API
In s_stream, first start/stop the sensor
remove chatty 'number of lanes' message]
Signed-off-by: Eugen Hristev <redacted>
[conor.dooley@microchip.com: fix potential uninitialized variable use]
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
[eugen.hristev@microchip.com: port to kernel 5.16, 5.17]
Signed-off-by: Eugen Hristev <redacted>
Same comment than on the 4th patch, this isn't very readable or relevant.
I'd imagine it can just be collapsed into a Co-developed-by & a signoff
as we hardly need multiple w/ the same names & companies involved each
time.
My "contribution" here (initialising some variables) doesn't warrant
inclusion IMO.

Eugen doesn't work for Microchip anymore though, and I don't know what
the plan for continuing the upstreaming of this driver is.

@Nicolas, do you have a plan here?

Cheers,
Conor.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help