Re: [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA controller node names in example
From: Rob Herring <robh@kernel.org>
Date: 2022-10-28 19:39:04
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Thu, Oct 27, 2022 at 01:49:20PM +0900, Kunihiko Hayashi wrote:
quoted hunk ↗ jump to hunk
The word "glue" is ambiguous for the controller node name. Should put "sata-controller" instead of "ahci-glue" on the controller node. And rename a phy node to "sata-phy". Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml index a3cd45acea28..89b8b133777a 100644 --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml@@ -117,14 +117,14 @@ additionalProperties: false examples: - | - ahci-glue@65700000 { + sata-controller@65700000 {
But is this really the SATA controller aka AHCI? In cases where we don't have a standardized name, I don't think it makes sense changing node names from one non-standard name to another.
compatible = "socionext,uniphier-pxs3-ahci-glue",
"simple-mfd";
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x65700000 0x100>;
- ahci_phy: phy@10 {
+ ahci_phy: sata-phy@10 {
compatible = "socionext,uniphier-pxs3-ahci-phy";
reg = <0x10 0x10>;
#phy-cells = <0>;
--
2.25.1
-- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy