Thread (50 messages) 50 messages, 8 authors, 2022-11-07

Re: [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding

From: Krzysztof Kozlowski <hidden>
Date: 2022-10-28 02:20:08
Also in: linux-devicetree, linux-i2c, linux-tegra, linux-usb, lkml

On 25/10/2022 04:02, Wayne Chang wrote:
quoted
quoted
+  power-domain-names:
+    items:
+      - const: xusb_host
+      - const: xusb_ss
Drop 'xusb_'.
The properties are constant and we use the name to get the power domain.

	tegra->genpd_dev_host = dev_pm_domain_attach_by_name(dev, "xusb_host");
	
	tegra->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "xusb_ss");
	
we might not be able to drop the xusb_
These are new bindings, so why do say they are "constant"? New bindings
means you did not use them. If you used them before bindings... what can
we say? Don't?

Best regards,
Krzysztof


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help