On Wed, 2022-09-28 at 15:35 +0200, AngeloGioacchino Del Regno wrote:

Il 28/09/22 11:30, Chunfeng Yun ha scritto:

quoted

These debugfs files are mainly used to make eye diagram test
easier,
especially helpful to do HQA test for a new IC without efuse
enabled.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Even though this won't be interesting for the vast majority of the
people
out there (the users!), it's still nice to have it for IC testing
performed
directly on upstream, as that opens new possibilities for you and
ODMs/OEMs,
so I agree on getting that code upstreamed.

For that reason, I think that the best approach for this one would be
to
enclose it in a configuration option like CONFIG_PHY_MTK_TPHY_DEBUGFS
or
CONFIG_PHY_MTK_TPHY_DEBUG, so that this very low level debugging code
doesn't end up in end-user builds, as that may, in some cases, be
even
dangerous.

Yes, It seems better, I'll modify it, thanks a lot

Regards,
Angelo

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy