Thread (36 messages) 36 messages, 4 authors, 2022-09-20

Re: [PATCH 16/16] phy: qcom-qmp-usb: shorten function prefixes

From: Dmitry Baryshkov <hidden>
Date: 2022-09-09 09:49:02
Also in: linux-arm-msm, lkml

On 07/09/2022 14:07, Johan Hovold wrote:
quoted hunk ↗ jump to hunk
The driver function prefix has gotten unnecessarily long and hurts
readability.

Shorten "qcom_qmp_phy_" to "qmp_" (which likely stands for "Qualcomm
Multi PHY" or similar anyway).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c |   3 +-
  drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 121 ++++++++++++------------
  2 files changed, 60 insertions(+), 64 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index b020409b92e0..4d0eee620f37 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -1105,8 +1105,7 @@ static const struct phy_ops qcom_qmp_ufs_ops = {
  	.owner		= THIS_MODULE,
  };
  
-static
-int qmp_ufs_create(struct device *dev, struct device_node *np, int id,
+static int qmp_ufs_create(struct device *dev, struct device_node *np, int id,
  			void __iomem *serdes, const struct qmp_phy_cfg *cfg)
This likely should go to the previous patch.

Otherwise:

Reviewed-by: Dmitry Baryshkov <redacted>

quoted hunk ↗ jump to hunk
  {
  	struct qcom_qmp *qmp = dev_get_drvdata(dev);
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index 08e0799e8832..41635c21e3ca 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
-- 
With best wishes
Dmitry


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help